ITEMS_MODULE

If you have created a 3rd party module you'd like other people to use, post it here
Tyrence
Posts: 1948
Joined: Sat Jan 09, 2010 1:32 am

Re: ITEMS_MODULE

Postby Tyrence » Wed May 13, 2015 2:47 pm

longsdale wrote:i would like the cidb implementation.here is a link from an older implementation.
and the cidb looks like its good for the db.

https://github.com/Savagedlight/Budabot/commit/ba554e322ac1afb0d34a1ac5dc4d6f151fd49d0e

Yeah, I have already added the CIDB support, although I used my own implementation in order to make it look and feel like the rest of Budabot and to fix an issue.
"Those who expect to reap the blessings of freedom, must, like men, undergo the fatigues of supporting it." — Thomas Paine
"Nearly all men stand adversity, but if you want to test a man's character, give him power." — Abraham Lincoln
Budabot Releases and Downloads: https://github.com/Budabot/Budabot/releases
longsdale
Member
Posts: 2
Joined: Wed May 13, 2015 6:06 am
antispam: Rimor

Re: ITEMS_MODULE

Postby longsdale » Wed May 13, 2015 9:21 pm

i want that ^^.i didnt used that from the link,just wanted to wait until u have something :)
Tyrence
Posts: 1948
Joined: Sat Jan 09, 2010 1:32 am

Re: ITEMS_MODULE

Postby Tyrence » Fri May 29, 2015 7:42 am

So, CIDB support was added to 3.3_RC1. However, it appears there are some issues with the searches, and with no way to contact Demoder to fix them, I will probably have to revert the bot back to using the local database.
"Those who expect to reap the blessings of freedom, must, like men, undergo the fatigues of supporting it." — Thomas Paine
"Nearly all men stand adversity, but if you want to test a man's character, give him power." — Abraham Lincoln
Budabot Releases and Downloads: https://github.com/Budabot/Budabot/releases
Tyrence
Posts: 1948
Joined: Sat Jan 09, 2010 1:32 am

Re: ITEMS_MODULE

Postby Tyrence » Thu Jun 11, 2015 11:47 pm

I added support for aoitems.com (also called CIDB) to the !items command and that was released with Budabot 3.3_RC1. After several weeks of testing, we found that aoitems.com provides much less search capabilities than the local items db provides. Specifically, aoitems.com consistently returns no results for searches that the local items db returns results for.

I have not been able to get Demoder to respond to these issues. It is unclear if she got the messages and chose not to respond or if she did not get the messages. In any case, I have removed support for aoitems.com from the current version. This change will be in the next version (3.3_RC2) and going forward for the foreseeable future. I hope that the issues will be fixed in which case we will re-visit this for a future release.
"Those who expect to reap the blessings of freedom, must, like men, undergo the fatigues of supporting it." — Thomas Paine
"Nearly all men stand adversity, but if you want to test a man's character, give him power." — Abraham Lincoln
Budabot Releases and Downloads: https://github.com/Budabot/Budabot/releases
iComa
Member
Posts: 17
Joined: Mon Mar 18, 2013 3:21 pm
antispam: Rimor

Re: ITEMS_MODULE

Postby iComa » Wed Jun 24, 2015 4:46 pm

Hi! Just want to know, maybe i wrong. Items command not working if item name contains dash symbol, for example:
xxx: !items kyr'ozch energy hammer - type 112
yyy: No items found matching kyr'ozch energy hammer - type 112.

and if i write:
xxx: !items kyr'ozch energy hammer
yyy: Item Search Results (8)

I dont know if it's on all items with dash symbol, but i tried some and its all have that problem. Don't blame me pls ;)
Teeko
The Team
Posts: 191
Joined: Tue Mar 08, 2011 8:57 am
antispam: Rimor

Re: ITEMS_MODULE

Postby Teeko » Thu Jun 25, 2015 1:02 pm

That is the way search works, it is like google's search. If you add a - to the search, anything after that is excluded.
iComa
Member
Posts: 17
Joined: Mon Mar 18, 2013 3:21 pm
antispam: Rimor

Re: ITEMS_MODULE

Postby iComa » Thu Jun 25, 2015 1:04 pm

I see. Thanks for answer.
Tyrence
Posts: 1948
Joined: Sat Jan 09, 2010 1:32 am

Re: ITEMS_MODULE

Postby Tyrence » Sat Jun 27, 2015 6:22 pm

I believe that is only the case when using the CIDB, so this is another thing we should add to the list of things to fix with that.

When using the local database, the original search should return results. If it doesn't, then that is a bug we should fix. Specifically, the minus sign (-) should be treated normally if it's not the first character of a word, or if it's the only character in a word. I am in an airport at the moment, but maybe someone else could test this using the local items db and verify?
"Those who expect to reap the blessings of freedom, must, like men, undergo the fatigues of supporting it." — Thomas Paine
"Nearly all men stand adversity, but if you want to test a man's character, give him power." — Abraham Lincoln
Budabot Releases and Downloads: https://github.com/Budabot/Budabot/releases
Tyrence
Posts: 1948
Joined: Sat Jan 09, 2010 1:32 am

Re: ITEMS_MODULE

Postby Tyrence » Sun Jun 28, 2015 5:18 am

Teeko was right in that this is how it works currently, even with the local database. This is a bug and I will put a fix in for it for the final 3.3 release.
"Those who expect to reap the blessings of freedom, must, like men, undergo the fatigues of supporting it." — Thomas Paine
"Nearly all men stand adversity, but if you want to test a man's character, give him power." — Abraham Lincoln
Budabot Releases and Downloads: https://github.com/Budabot/Budabot/releases
iComa
Member
Posts: 17
Joined: Mon Mar 18, 2013 3:21 pm
antispam: Rimor

Re: ITEMS_MODULE

Postby iComa » Tue Nov 10, 2015 9:01 pm

Hi guys! Do you plan to update local DB to 18.8.8 ? =)

Return to “Modules”

Who is online

Users browsing this forum: No registered users and 1 guest